Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt CAConstants for HIon #34811

Closed
wants to merge 547 commits into from

Conversation

stahlleiton
Copy link
Contributor

This PR include changes needed to avoid overflow while running the patatrack pixel tracking on HIon HLT menu using 2018 PbPb data.

The changes increase the thresholds of the following CA constants:

  • maxNumberOfTuples : increased from 24 * 1024 to 32 * 1024 to avoid overflow on number of tuples.
  • maxCellsPerHit : increased from 128 to 2 * 128 to avoid overflow on OuterHitOfCell.

PR validation:

The changes were tested on 2018 PbPb data using the HardProbe PDs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@fwyzard

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34811/24555

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

  • RecoPixelVertexing/PixelTriplets (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Aug 6, 2021

enable gpu

@fwyzard
Copy link
Contributor

fwyzard commented Aug 6, 2021

please test

@fwyzard
Copy link
Contributor

fwyzard commented Aug 6, 2021

assign heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34811/24556

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

Pull request #34811 was updated. @perrotta, @makortel, @fwyzard, @jpata, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45810e/17611/summary.html
COMMIT: aabb0db
CMSSW: CMSSW_12_1_X_2021-08-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34811/17611/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
  • 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
  • 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999410
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999381
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@stahlleiton
Copy link
Contributor Author

Sorry, seems I made a mistake while trying to go to a different release (the daily CMSSW development release I was using had already expired).

How do I go to a newer release without all commits appearing in the history?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34811/24869

@stahlleiton stahlleiton deleted the CMSSW_12_1_X_GPU_HIon_v1 branch September 1, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment